[Feature Cleanup] Remove APIServerIdentity from test, bump api group to beta #35941
Conversation
|
Skipping CI for Draft Pull Request. |
k8s-ci-robot
added
do-not-merge/work-in-progress
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: mariafromano-25 The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/test pull-kube-storage-version-migrator-disruptive |
|
@mariafromano-25: The specified target(s) for Use In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
| - --timeout=50m | ||
| - --runtime-config=internal.apiserver.k8s.io/v1alpha1=true | ||
| - --env=KUBE_FEATURE_GATES=StorageVersionAPI=true,APIServerIdentity=true | ||
| - --runtime-config=internal.apiserver.k8s.io/v1beta1=true |
There was a problem hiding this comment.
is it enabled by default or should be explicitly enabled?
There was a problem hiding this comment.
I realized the internal.apiserver.k8s.io API is for StorageVersionAPI, not for APIServerIdentity. StorageVersionAPI and internal.apiserver.k8s.io are still in alpha and need to be explicitly enabled.
There was a problem hiding this comment.
@mariafromano-25 The files being modified are for StorageVersionAPI, which is a different feature than APIServerIdentity.
You can clean up APIServerIdentity=true since this feature gate is now beta and enabled by default, but you need to keep internal.apiserver.k8s.io/v1alpha1=true and StorageVersionAPI=true since these are the alpha API & feature gate for the StorageVersionAPI test to work.
k8s-ci-robot
removed
the
do-not-merge/work-in-progress
4 participants
/kind cleanup
Continuing the efforts of kubernetes/kubernetes#134172
Correspinding to PR kubernetes/kubernetes#135360
Currently as draft so I can run the specific test jobs and compare the output to see if the env variable is enabled by default and if the API should be set to beta or can be removed.
cc: @SergeyKanzhelev @roycaihw